OpenID: Clarify the impact of errors to users and admins

Related progress issue: https://progress.opensuse.org/issues/167266
os-autoinst · Oct 4, 2024 · 35d43a8 · 35d43a8
1 parent 43cd403
commit 35d43a8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/OpenQA/WebAPI/Auth/OpenID.pm b/lib/OpenQA/WebAPI/Auth/OpenID.pm
@@ -102,15 +102,16 @@ sub auth_response ($c) {
     );
 
     my $err_handler = sub ($err, $txt) {
-        $c->app->log->error("OpenID: $err: $txt");
-        $c->flash(error => "$err: $txt");
+        $c->app->log->error("OpenID: $err: $txt. Consider a report to the authentication server administrators.");
+        $c->flash(error => "$err: $txt. Please retry again. "
+              . 'If this reproduces please report the problem to the system administrators.');
         return (error => 0);
     };
 
     $csr->handle_server_response(
         not_openid => sub () {
             my $op_uri = $params{'openid.op_endpoint'} // '';
-            $err_handler->('Failed to login', "OpenID provider '$op_uri' returned invalid data. Please retry again");
+            $err_handler->('Failed to login', "OpenID provider '$op_uri' returned invalid data on a login attempt.");
         },
         setup_needed => sub ($setup_url) {
             # Redirect the user to $setup_url