Use perlcritic wrapper and plugins from common repo

Also create a github workflow for it Issue: https://progress.opensuse.org/issues/155188
os-autoinst · Aug 13, 2024 · af154c0 · af154c0
1 parent d13bdfa
commit af154c0
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 42 deletions.
diff --git a/.github/workflows/perl-critic.yml b/.github/workflows/perl-critic.yml
@@ -0,0 +1,14 @@
+---
+name: 'Perl critic'
+
+on: [push, pull_request]
+
+jobs:
+  perl-critic-checks:
+    runs-on: ubuntu-latest
+    name: "Perlcritic"
+    container:
+      image: perldocker/perl-tester
+    steps:
+      - uses: actions/checkout@v4
+      - run: make test-critic
diff --git a/.perlcriticrc b/.perlcriticrc
diff --git a/.perlcriticrc b/.perlcriticrc
@@ -0,0 +1 @@
+external/os-autoinst-common/.perlcriticrc
diff --git a/Makefile b/Makefile
@@ -293,7 +293,7 @@ endif
 
 .PHONY: test-critic
 test-critic:
-	PERL5LIB=lib/perlcritic:$$PERL5LIB perlcritic lib
+	tools/perlcritic lib
 
 .PHONY: test-tidy-compile
 test-tidy-compile:

diff --git a/lib/perlcritic/Perl/Critic/Policy/HashKeyQuotes.pm b/lib/perlcritic/Perl/Critic/Policy/HashKeyQuotes.pm
diff --git a/tools/perlcritic b/tools/perlcritic
@@ -0,0 +1 @@
+../external/os-autoinst-common/tools/perlcritic