Skip to content

Commit

Permalink
Skip symlinks in enqueue_git_update_all
Browse files Browse the repository at this point in the history
I forgot that `-d` is actually true for symlinks.

It resulted in the gru task processing over the same realpaths, trying
to get a guard for the same path multiple times, which failed and ran
int an endless retry.

Issue: https://progress.opensuse.org/issues/164898
  • Loading branch information
perlpunk authored and okurz committed Sep 28, 2024
1 parent fbbcf84 commit bb8d06e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/OpenQA/Shared/Plugin/Gru.pm
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,12 @@ sub enqueue_git_update_all ($self) {
my %clones;
my $testdir = path(sharedir() . '/tests');
for my $distri ($testdir->list({dir => 1})->each) {
next unless -d $distri; # no symlinks
next if -l $distri; # no symlinks
next unless -e $distri->child('.git');
$clones{$distri} = undef;
if (-e $distri->child('products')) {
for my $product ($distri->child('products')->list({dir => 1})->each) {
next unless -d $product; # no symlinks
next if -l $product; # no symlinks
my $needle = $product->child('needles');
next unless -e $needle->child('.git');
$clones{$needle} = undef;
Expand Down

0 comments on commit bb8d06e

Please sign in to comment.