Skip to content

Commit

Permalink
Remove tour to drop problematic dependency
Browse files Browse the repository at this point in the history
* Drop problematic dependency `shepherd.js`
* Keep the database column to avoid a problematic database migration
* Keep the API endpoint to set the tour progress to avoid a breaking API
  change
* Note that we might want to repurpose the database column and API in the
  future to show a simple help notification for new users
* Add a very small test for the feature API so it is still covered after
  removing the UI test of the feature tour
* Remove all UI code related to the tour
* See https://progress.opensuse.org/issues/163004 for further reasoning
  • Loading branch information
Martchus committed Aug 15, 2024
1 parent ab9f78b commit c2223d1
Show file tree
Hide file tree
Showing 16 changed files with 5 additions and 455 deletions.
2 changes: 0 additions & 2 deletions assets/assetpack.def
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@
< javascripts/filter_form.js
< javascripts/comments.js
< javascripts/keyevent.js
< javascripts/feature.js
< javascripts/fullscreen.js
< javascripts/obs_rsync.js
< javascripts/parent_group_overview.js
Expand All @@ -150,7 +149,6 @@
< ../node_modules/chosen-js/chosen.jquery.js
< ../node_modules/jquery-ujs/src/rails.js
< javascripts/disable_animations.js [mode==test]
< ../node_modules/shepherd.js/dist/js/shepherd.min.js

! anser.js
< javascripts/anser-import.js
Expand Down
125 changes: 0 additions & 125 deletions assets/javascripts/feature.js

This file was deleted.

1 change: 0 additions & 1 deletion assets/stylesheets/openqa.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,3 @@ dummy { font-size: 42px; }
@import "comments.scss";
@import "overview.scss";
@import "parent_group_overview.scss";
@import "shepherd.scss";
183 changes: 0 additions & 183 deletions assets/stylesheets/shepherd.scss

This file was deleted.

2 changes: 1 addition & 1 deletion lib/OpenQA/WebAPI/Controller/API/V1/Feature.pm
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Implements feature API.
=item informed()
Post integer value to save feature tour progress of current user in the database
Post integer value to save feature version of current user in the database
=back
Expand Down
Loading

0 comments on commit c2223d1

Please sign in to comment.