-
Notifications
You must be signed in to change notification settings - Fork 208
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use perlcritic wrapper and plugins from common repo
- Loading branch information
Showing
4 changed files
with
46 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,49 @@ | ||
theme = freenode | ||
theme = community + openqa | ||
severity = 4 | ||
include = strict ValuesAndExpressions::ProhibitInterpolationOfLiterals | ||
|
||
# TODO: Remove once Perl::Critic::Freenode 0.028 is widely available | ||
[Freenode::DiscouragedModules] | ||
verbose = ::warning file=%f,line=%l,col=%c,title=%m - severity %s::[%p] %e\n | ||
|
||
# == Perlcritic Policies | ||
# -- Test::Most brings in strict & warnings | ||
[TestingAndDebugging::RequireUseStrict] | ||
equivalent_modules = Test::Most | ||
|
||
[TestingAndDebugging::RequireUseWarnings] | ||
equivalent_modules = Test::Most | ||
|
||
# -- Avoid double quotes unless there's interpolation or a single quote. | ||
[ValuesAndExpressions::ProhibitInterpolationOfLiterals] | ||
allow_if_string_contains_single_quote = 1 | ||
severity = 3 | ||
|
||
[Perl::Critic::Policy::HashKeyQuotes] | ||
# -- Prohibit deep nesting | ||
[ControlStructures::ProhibitDeepNests] | ||
severity = 4 | ||
add_themes = community | ||
max_nests = 4 | ||
|
||
# == Community Policies | ||
# -- Test::Most brings in strict & warnings | ||
[Freenode::StrictWarnings] | ||
extra_importers = Test::Most | ||
|
||
# -- Test::Most brings in strict & warnings | ||
[Community::StrictWarnings] | ||
extra_importers = Test::Most | ||
|
||
[Community::DiscouragedModules] | ||
severity = 3 | ||
|
||
# Test modules have no package declaration | ||
[Community::PackageMatchesFilename] | ||
severity = 1 | ||
|
||
# == Custom Policies | ||
# -- Useless quotes on hashes | ||
[HashKeyQuotes] | ||
severity = 5 | ||
|
||
# -- Superfluous use strict/warning. | ||
[RedundantStrictWarning] | ||
equivalent_modules = Test::Most |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../external/os-autoinst-common/tools/perlcritic |