PART 2: WebAPI::Controller::Running: Remove uncovered close_connection handler - After #5755

[okurz]

After:

• Use signatures in WebAPI::Controller::Running #4961
• Use signatures in Shared::Controller::Running #5755

[Martchus]

We should likely close the connection here as the code previously did. Otherwise we'd leave the client waiting for further data until a timeout occurs. Placing a die here seems generally wrong as it would likely just be caught by Mojolicious' handler. The message has also not enough context to be useful in the server-side logs (where it would end up). If we wanted better error handling, then an error should likely go to the client in form of a bad return code.

[okurz]

ok, I agree. All CI tests passing show that we are missing test coverage here

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.43%. Comparing base (63bc4d0) to head (f838979).
Report is 49 commits behind head on master.

Files	Patch %	Lines
lib/OpenQA/Shared/Controller/Running.pm	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4898      +/-   ##
==========================================
- Coverage   98.43%   98.43%   -0.01%     
==========================================
  Files         393      393              
  Lines       38594    38593       -1     
==========================================
- Hits        37991    37990       -1     
  Misses        603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.