Remove unused 'dsn' function and its usage

[okurz]

Tests did not cover the 'dsn' function anyway.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (64488e5) to head (b1da48e).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   98.49%   98.50%   +0.01%     
==========================================
  Files         394      394              
  Lines       38683    38678       -5     
==========================================
  Hits        38099    38099              
+ Misses        584      579       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[okurz]

Removed superfluous ' in the git commit message subject line

[Martchus]

This change looks wrong. At least the commit message is misleading (as I only see a function being removed but not moved/inlined).

[Martchus]

I guess we don't need this way of specifying credentials anymore then.

[baierjan]

There is an issue in production due to this:

Aug 01 13:56:01 ariel openqa-webui-daemon[10603]: Can't connect to data source 'HASH(0x5585ac6ef2e8)' because I can't work out what driver to use (it doesn't seem to contain a 'dbi:driver:' prefix and the DBI_DRIVER env var is not set) at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/Pg.pm line 73.

[okurz]

The good thing is that we saw this in docker-compose tests. I wonder if I can change the docker-compose tests to actually test the branch related to a pull request as we build packages in there - if that's not taking too long.

[Martchus]

That would mean the execution of the docker-compose tests needs to happen after the OBS checks have built and published the packages. Not sure whether we can easily chain OBS checks and docker-compose tests as they are triggered/executed in a completely different way.

[baierjan]

That would mean the execution of the docker-compose tests needs to happen after the OBS checks have built and published the packages. Not sure whether we can easily chain OBS checks and docker-compose tests as they are triggered/executed in a completely different way.

In the helm chart tests (which also failed), it pulls the container images from OBS. The docker-compose test does the build on its own. The test is calling docker compose build

openQA/tools/test_containers_compose

Line 30 in 4389076

"$thisdir"/retry sudo docker compose build

then note that there is no OBS image specified in

openQA/container/webui/docker-compose.yaml

Line 88 in 4389076

image: openqa_webui

which should use the folder with the same name as the source of the container and build it if not present locally. You can see the build in the test logs. The problem is, that the Dockerfile is using openQA package from the distribution and not from the git as you can see in the failing docker-compose test here: https://github.com/os-autoinst/openQA/actions/runs/10199794743/job/28217764031#step:3:989

Another possible solution could be a new Dockerfile to build openQA container locally from git (but that would be duplicating the work OBS does for us) or as was already mentioned, wait for OBS, but even in that case we need to modify the Dockerfile to use the packages from the correct branch and not the released ones from our devel repo.

[okurz]

ok, nevermind the docker-compose ideas. Now second try for the original change but with full test coverage of the changed code:

• Move 'dsn' functionality into only place where used #5815