Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use perlcritic from os-autoinst-common #5459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Feb 7, 2024

OpenQA is ready for adapt the perlcriticrc from os-autoinst-common.

https://progress.opensuse.org/issues/138416

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/perlcritc/perlcritic/

@b10n1k b10n1k changed the title Use perlcritc from os-autoinst-commom Use perlcritrc from os-autoinst-commom Feb 7, 2024
@b10n1k b10n1k changed the title Use perlcritrc from os-autoinst-commom Use perlcritic from os-autoinst-commom Feb 7, 2024
@b10n1k
Copy link
Contributor Author

b10n1k commented Feb 9, 2024

I update the os-autoinst-common as the checkstyle keeps failing #5465

@okurz
Copy link
Member

okurz commented Feb 9, 2024

s/commom/common/

@kalikiana
Copy link
Member

kalikiana commented Feb 14, 2024

@b10n1k Please consider this open suggestion, and there is a CI check failing:

::warning file=lib/OpenQA/WebAPI/Controller/Test.pm,line=99,col=5,title=Hash key with quotes - severity 5::[HashKeyQuotes] Avoid useless quotes

Maybe consider os-autoinst/os-autoinst-common#42 here?

s/commom/common/

@b10n1k b10n1k changed the title Use perlcritic from os-autoinst-commom Use perlcritic from os-autoinst-common Feb 15, 2024
OpenQA is ready for adapt the perlcriticrc from os-autoinst-common.
https://progress.opensuse.org/issues/138416

Signed-off-by: ybonatakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants