Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install npm in the container we use on CircleCI #5473

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Install npm in the container we use on CircleCI #5473

merged 1 commit into from
Feb 13, 2024

Conversation

Martchus
Copy link
Contributor

  • This will allow us to remove the manual zypper call in the asset caching step.
  • This was supposed to happen in c5ea52b but this commit only changed the development container and not the one actually used on CircleCI.
  • See https://progress.opensuse.org/issues/153427

@Martchus
Install npm in the container we use on CircleCI
65ab7b5 
* This will allow us to remove the manual zypper call in the asset caching
  step.
* This was supposed to happen in
  c5ea52b but this commit only changed
  the development container and not the one actually used on CircleCI.
* See https://progress.opensuse.org/issues/153427
@Martchus Martchus mentioned this pull request Feb 13, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22c1d75) 98.38% compared to head (65ab7b5) 98.37%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5473      +/-   ##
==========================================
- Coverage   98.38%   98.37%   -0.02%     
==========================================
  Files         390      390              
  Lines       37862    37862              
==========================================
- Hits        37250    37245       -5     
- Misses        612      617       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit ab8c92c into os-autoinst:master Feb 13, 2024
42 checks passed
@Martchus Martchus deleted the container-npm branch February 13, 2024 22:04
os-autoinst-bot pushed a commit to os-autoinst-bot/openQA that referenced this pull request Feb 14, 2024
Update documentation to commit ab8c92c
319e67a 
commit ab8c92c
Merge: 22c1d75 65ab7b5
Author:     mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
AuthorDate: Tue Feb 13 18:53:18 2024 +0000
Commit:     GitHub <[email protected]>
CommitDate: Tue Feb 13 18:53:18 2024 +0000

    Merge pull request os-autoinst#5473 from Martchus/container-npm

    Install npm in the container we use on CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz approved these changes

@kalikiana kalikiana kalikiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Martchus @kalikiana @okurz