-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: More signatures #5511
Draft
okurz
wants to merge
5
commits into
os-autoinst:master
Choose a base branch
from
okurz:feature/style_warnings_strict_base_signatures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: More signatures #5511
okurz
wants to merge
5
commits into
os-autoinst:master
from
okurz:feature/style_warnings_strict_base_signatures
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
okurz
commented
Mar 14, 2024
•
edited
Loading
edited
- Simplify Resource::Locks with direct return of boolean calculations
- Use signatures in Resource::Locks
- Slightly simplify script/openqa-validate-yaml
- Use signatures in WebAPI::ServerSideDataTable
- Use signatures in Resource::Jobs
okurz
force-pushed
the
feature/style_warnings_strict_base_signatures
branch
from
March 14, 2024 08:49
7126762
to
e343040
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5511 +/- ##
=======================================
Coverage 98.38% 98.39%
=======================================
Files 391 391
Lines 37883 37874 -9
=======================================
- Hits 37271 37265 -6
+ Misses 612 609 -3 ☔ View full report in Codecov by Sentry. |
okurz
force-pushed
the
feature/style_warnings_strict_base_signatures
branch
from
March 14, 2024 09:13
e343040
to
b295d47
Compare
This pull request is now in conflicts. Could you fix it? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.