Prevent live view viewers from making openQA unresponsive #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
force-pushed
the
separate-streaming
branch
from
950ba1c
to
ab1aa5c
Compare
okurz
approved these changes
Jul 10, 2024
|
* Avoid live view viewers from occupying too many Mojolicious workers by moving the image streaming of the live mode to the live handler daemon * Make sure the frontend code can still connect to the streaming route in a development setup by taking the different port into account and by setting CORS headers * Tested by running the main web UI service allowing only a limited number of connections via `script/openqa prefork -c 1 -w 1`. This causes it to be unresponsive if there is at least one live view tab open. With this change this is no longer a problem and multiple live tabs can be opened and are updated simultaneously. * Tested without and with reverse proxy.
Martchus
force-pushed
the
separate-streaming
branch
from
ab1aa5c
to
247a6ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5754 +/- ##
==========================================
- Coverage 98.45% 98.43% -0.02%
==========================================
Files 393 393
Lines 38585 38594 +9
==========================================
+ Hits 37989 37991 +2
- Misses 596 603 +7 ☔ View full report in Codecov by Sentry. |
perlpunk
approved these changes
Jul 10, 2024
|
This might be related: https://progress.opensuse.org/issues/163931 |
|
Right, well have to move that helper to the shared helpers. I assume you'll take care of it considering you've already assigned yourself to the ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script/openqa prefork -c 1 -w 1. This causes it to be unresponsive if there is at least one live view tab open. With this change this is no longer a problem and multiple live tabs can be opened and are updated simultaneously.