Implement option to configure the hmac time difference tolerance #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
requested changes
Jul 23, 2024
This avoids unexpected behaviour if the timestamp of a worker is ahead of the webuis time.
nicksinger
force-pushed
the
hmac_tolerance
branch
from
46a4bec
to
3883e61
Compare
okurz
approved these changes
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5787 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 394 394
Lines 38676 38677 +1
=======================================
+ Hits 38088 38089 +1
Misses 588 588 ☔ View full report in Codecov by Sentry. |
perlpunk
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if I should split out 46a4bec into a different PR