Lower the log level of livestream related problem considering low impact #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error condition has no impact on the job execution. It just means that the web socket server is not ready yet as we saw in https://progress.opensuse.org/issues/164709#note-4. The request is already retried on the client-side so the live view will be able to resume once the web socket server is ready and the worker connected back. I tested this locally by entering the "Live" tab while the web socket server is not running. When starting it the live view updates itself after a few seconds (without having to switch tabs or reloading the page).
perlpunk
approved these changes
Jul 31, 2024
okurz
approved these changes
Jul 31, 2024
okurz
reviewed
Jul 31, 2024
Comment on lines
170
to
+171
| $msg = "Unable to ask worker $worker_id to $verb providing livestream for $job_id: $msg"; | ||
| log_error $msg; | ||
| log_debug $msg; |
There was a problem hiding this comment.
maybe instead of just explaining in the git commit message you can also reword the message to not only state the "what" but also the "so what"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5807 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 394 394
Lines 38686 38686
=======================================
Hits 38102 38102
Misses 584 584 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error condition has no impact on the job execution. It just means that the web socket server is not ready yet as we saw in https://progress.opensuse.org/issues/164709#note-4. The request is already retried on the client-side so the live view will be able to resume once the web socket server is ready and the worker connected back. I tested this locally by entering the "Live" tab while the web socket server is not running. When starting it the live view updates itself after a few seconds (without having to switch tabs or reloading the page).