Simplify error handling of downloader, avoid confusing error codes #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
approved these changes
Aug 1, 2024
* Remove the made-up HTTP response codes introduced by aea93ad (e.g. just log `Connect timeout` instead of `521 Connect timeout`) * Simplify the code * Keep retry behavior as-is, so if there's no response code at all or a real 5xx error code the downloader tries again * Simplify code * See https://progress.opensuse.org/issues/164222
Martchus
force-pushed
the
downloader-error-handling
branch
from
85500a2
to
0be1071
Compare
|
https://app.circleci.com/pipelines/github/os-autoinst/openQA/14169/workflows/a981fe7c-0ad6-4b81-ab31-da16ee5a40fa/jobs/133633 failed with what should be #5809 . Make sure to have rebased on that one. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5810 +/- ##
==========================================
- Coverage 98.49% 98.49% -0.01%
==========================================
Files 394 394
Lines 38685 38683 -2
==========================================
- Hits 38101 38099 -2
Misses 584 584 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect timeoutinstead of521 Connect timeout)