Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openqa-bootstrap: Refresh and retry in case of package changes #5840

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

kalikiana
Copy link
Member

Packages may be deleted before they can be installed.

See: https://progress.opensuse.org/issues/165024

script/openqa-bootstrap Outdated Show resolved Hide resolved
@kalikiana kalikiana force-pushed the bs_retry branch 3 times, most recently from 4ec8a6f to f276739 Compare August 9, 2024 11:46
@kalikiana kalikiana marked this pull request as ready for review August 9, 2024 11:47
@okurz
Copy link
Member

okurz commented Aug 9, 2024

From CI checks:

+ make test-checkstyle
shellcheck -x $(file --mime-type script/* t/* container/worker/*.sh tools/* | sed -n 's/^\(.*\):.*text\/x-shellscript.*$/\1/p')

In script/openqa-bootstrap line 98:
packages="${pkgs[@]}"
         ^----------^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

For more information:
  https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A...
make: *** [Makefile:302: test-shellcheck] Error 1

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another failed style check but trivial to fix

script/openqa-bootstrap Outdated Show resolved Hide resolved
@mergify mergify bot merged commit e404d96 into os-autoinst:master Aug 9, 2024
42 checks passed
os-autoinst-bot pushed a commit to os-autoinst-bot/openQA that referenced this pull request Aug 10, 2024
commit e404d96
Merge: 9afc3ef 708bbe7
Author:     mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
AuthorDate: Fri Aug 9 18:35:12 2024 +0000
Commit:     GitHub <[email protected]>
CommitDate: Fri Aug 9 18:35:12 2024 +0000

    Merge pull request os-autoinst#5840 from kalikiana/bs_retry

    openqa-bootstrap: Refresh and retry in case of package changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants