Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use perlcritic wrapper and plugins from common repo #5843

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Aug 12, 2024

Also create a github workflow for it.

Issue: https://progress.opensuse.org/issues/155188

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching external/**:

  • Consider doing this change in the upstream repository directly, see external/os-autoinst-common/README.md

This is an automatically generated QA checklist based on modified files.

@perlpunk perlpunk force-pushed the perlcritic branch 2 times, most recently from 77d0aa0 to bfadb13 Compare August 12, 2024 11:07
@perlpunk perlpunk marked this pull request as ready for review August 12, 2024 11:10
@perlpunk
Copy link
Contributor Author

Ok, while trying to fix more perlcritic complaints I found out that the plugins actually need more fixes.
I wish those plugins had been tested on our code base before.

@perlpunk
Copy link
Contributor Author

After

@perlpunk
Copy link
Contributor Author

https://app.circleci.com/pipelines/github/perlpunk/openQA/357/workflows/d8ac13a9-ce17-413a-bbc2-8b9779b9e1a2/jobs/2482

[13:16:03] t/05-scheduler-full.t .. 1/? 
    #   Failed test 'jobs dispatched to different workers'
    #   at t/05-scheduler-full.t line 119.
    #          got: undef
    #     expected: anything else

    #   Failed test 'each of the two jobs allocated to one of the workers'
    #   at t/05-scheduler-full.t line 120.
    #          got: undef
    #     expected: anything else
    # 0
    # Looks like you failed 2 tests of 4.
[13:16:03] t/05-scheduler-full.t .. 2/? 
#   Failed test 'Scheduler worker job allocation'
#   at t/05-scheduler-full.t line 128.
...

This seems unrelated. I'll retrigger

@perlpunk
Copy link
Contributor Author

Created https://progress.opensuse.org/issues/165198 for the unrelated failing test

@perlpunk
Copy link
Contributor Author

So there seems to be a problem with circleci - I retriggered the failing test and it passed now, but the links in the github checks still link to the older run.
Also the codecov upload failed with the typical token error.
Let's see what happens when I rebase to trigger a completely new run

subrepo:
  subdir:   "external/os-autoinst-common"
  merged:   "5dc4bf41d"
upstream:
  origin:   "[email protected]:os-autoinst/os-autoinst-common.git"
  branch:   "master"
  commit:   "26141c039"
git-subrepo:
  version:  "0.4.6"
  origin:   "[email protected]:ingydotnet/git-subrepo"
  commit:   "110b9eb"
@mergify mergify bot merged commit bdea10a into os-autoinst:master Aug 13, 2024
43 checks passed
@perlpunk perlpunk deleted the perlcritic branch August 13, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants