Move simulating load to a function

[perlpunk]

Issue: https://progress.opensuse.org/issues/165198

[okurz]

perfect!

[okurz]

… or maybe not :D

[18:59:06] t/00-tidy.t ............... [18:59:06] t/00-tidy.t ............... 1/? 
#   Failed test 'tidy'
#   at t/00-tidy.t line 10.
#          got: '256'
#     expected: '0'
# Looks like you failed 1 test of 2.
                                            [18:59:06] t/00-tidy.t ............... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 
[19:00:42] t/01-compile-check-all.t .. 985/? [19:00:42] t/01-compile-check-all.t .. 988/? 
#   Failed test 'Syntax check t/24-worker-overall.t'
#   at /usr/lib/perl5/vendor_perl/5.26.1/Test/Strict.pm line 426.
# Global symbol "$load_avg_file_realpath" requires explicit package name (did you forget to declare "my $load_avg_file_realpath"?) at t/24-worker-overall.t line 825.
# Type of arg 1 to Test::Output::combined_like must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 827, near "'warning about not being able to detect average load logged';"
# Type of arg 1 to Test::Fatal::exception must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 835, near "},"
# Type of arg 1 to Test::Warnings::warning must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 863, near "},"
# Type of arg 1 to Test::Output::combined_like must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 866, near "'log for initial critical error and forcefull kill after second error';"
# t/24-worker-overall.t had compilation errors.
[19:00:42] t/01-compile-check-all.t .. 991/? [19:00:42] t/01-compile-check-all.t .. 994/? [19:00:42] t/01-compile-check-all.t .. 997/? [19:00:42] t/01-compile-check-all.t .. 1000/? [19:00:42] t/01-compile-check-all.t .. 1003/? [19:00:42] t/01-compile-check-all.t .. 1006/? [19:00:42] t/01-compile-check-all.t .. 1009/? [19:00:42] t/01-compile-check-all.t .. 1012/? [19:00:42] t/01-compile-check-all.t .. 1015/? [19:00:42] t/01-compile-check-all.t .. 1018/? [19:00:42] t/01-compile-check-all.t .. 1021/? [19:00:42] t/01-compile-check-all.t .. 1024/? [19:00:42] t/01-compile-check-all.t .. 1027/? [19:00:42] t/01-compile-check-all.t .. 1030/? [19:00:42] t/01-compile-check-all.t .. 1033/? [19:00:42] t/01-compile-check-all.t .. 1036/? [19:00:42] t/01-compile-check-all.t .. 1039/? [19:00:42] t/01-compile-check-all.t .. 1042/? [19:00:42] t/01-compile-check-all.t .. 1045/? [19:00:42] t/01-compile-check-all.t .. 1048/? [19:00:42] t/01-compile-check-all.t .. 1051/? [19:00:42] t/01-compile-check-all.t .. 1054/? [19:00:42] t/01-compile-check-all.t .. 1063/? [19:00:42] t/01-compile-check-all.t .. 1075/? [19:00:42] t/01-compile-check-all.t .. 1084/? [19:00:42] t/01-compile-check-all.t .. 1087/? [19:00:42] t/01-compile-check-all.t .. 1099/? [19:00:42] t/01-compile-check-all.t .. 1105/? [19:00:42] t/01-compile-check-all.t .. 1108/? [19:00:42] t/01-compile-check-all.t .. 1114/? [19:00:42] t/01-compile-check-all.t .. 1117/? [19:00:42] t/01-compile-check-all.t .. 1123/? [19:00:42] t/01-compile-check-all.t .. 1126/? [19:00:42] t/01-compile-check-all.t .. 1129/? [19:00:42] t/01-compile-check-all.t .. 1132/? [19:00:42] t/01-compile-check-all.t .. 1135/? [19:00:42] t/01-compile-check-all.t .. 1138/? [19:00:42] t/01-compile-check-all.t .. 1141/? [19:00:42] t/01-compile-check-all.t .. 1144/? [19:00:42] t/01-compile-check-all.t .. 1147/? [19:00:42] t/01-compile-check-all.t .. 1150/? [19:00:42] t/01-compile-check-all.t .. 1153/? [19:00:42] t/01-compile-check-all.t .. 1156/? [19:00:42] t/01-compile-check-all.t .. 1159/? [19:00:42] t/01-compile-check-all.t .. 1162/? [19:00:42] t/01-compile-check-all.t .. 1165/? [19:00:42] t/01-compile-check-all.t .. 1168/? [19:00:42] t/01-compile-check-all.t .. 1171/? [19:00:42] t/01-compile-check-all.t .. 1174/? [19:00:42] t/01-compile-check-all.t .. 1177/? [19:00:42] t/01-compile-check-all.t .. 1180/? [19:00:42] t/01-compile-check-all.t .. 1183/? [19:00:42] t/01-compile-check-all.t .. 1186/? [19:00:42] t/01-compile-check-all.t .. 1189/? [19:00:42] t/01-compile-check-all.t .. 1192/? [19:00:42] t/01-compile-check-all.t .. 1195/? [19:00:42] t/01-compile-check-all.t .. 1198/? [19:00:42] t/01-compile-check-all.t .. 1201/? [19:00:42] t/01-compile-check-all.t .. 1204/? [19:00:42] t/01-compile-check-all.t .. 1207/? [19:00:42] t/01-compile-check-all.t .. 1210/? [19:00:42] t/01-compile-check-all.t .. 1213/? [19:00:42] t/01-compile-check-all.t .. 1216/? [19:00:42] t/01-compile-check-all.t .. 1219/? [19:00:42] t/01-compile-check-all.t .. 1222/? [19:00:42] t/01-compile-check-all.t .. 1225/? [19:00:42] t/01-compile-check-all.t .. 1228/? [19:00:42] t/01-compile-check-all.t .. 1231/? [19:00:42] t/01-compile-check-all.t .. 1234/? [19:00:42] t/01-compile-check-all.t .. 1237/? # Looks like you failed 1 test of 1239.
                                               [19:00:42] t/01-compile-check-all.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1239 subtests

and

[19:05:31] t/24-worker-overall.t ..................................... Global symbol "$load_avg_file_realpath" requires explicit package name (did you forget to declare "my $load_avg_file_realpath"?) at t/24-worker-overall.t line 825.
Type of arg 1 to Test::Output::combined_like must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 827, near "'warning about not being able to detect average load logged';"
Type of arg 1 to Test::Fatal::exception must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 835, near "},"
Type of arg 1 to Test::Warnings::warning must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 863, near "},"
Type of arg 1 to Test::Output::combined_like must be block or sub {} (not reference constructor) at t/24-worker-overall.t line 866, near "'log for initial critical error and forcefull kill after second error';"
Execution of t/24-worker-overall.t aborted due to compilation errors.
[19:05:31] t/24-worker-overall.t .....................................   Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (f0932be) to head (b85ba2a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5853      +/-   ##
==========================================
- Coverage   98.50%   98.50%   -0.01%     
==========================================
  Files         395      395              
  Lines       38756    38753       -3     
==========================================
- Hits        38177    38174       -3     
  Misses        579      579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.