Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test coverage of OpenQA::Git #5854

Merged

Conversation

r-richardson
Copy link
Contributor

@okurz
Copy link
Member

okurz commented Aug 14, 2024

This was created as alternative approach to

I recommend against moving more tests into that file as long as they do not rely on a test database

@r-richardson r-richardson force-pushed the rename_and_extend_git_tests branch 2 times, most recently from d698970 to e933443 Compare August 15, 2024 10:14
@okurz okurz changed the title Rename and extend git tests Extend test coverage of OpenQA::Git Aug 15, 2024
@okurz okurz marked this pull request as ready for review August 15, 2024 10:15
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
perlpunk

This comment was marked as resolved.

@r-richardson r-richardson force-pushed the rename_and_extend_git_tests branch 2 times, most recently from 4336ce2 to d2bbe13 Compare August 15, 2024 11:20
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
@r-richardson r-richardson force-pushed the rename_and_extend_git_tests branch 2 times, most recently from 281af6a to a6b8654 Compare August 15, 2024 13:59
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one style suggestion for next time

t/16-utils-runcmd.t Outdated Show resolved Hide resolved
t/16-utils-runcmd.t Outdated Show resolved Hide resolved
@perlpunk
Copy link
Contributor

perlpunk commented Aug 15, 2024

I guess we have to force merge this because of the broken circleci test

Edit: @r-richardson fixed it

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (9a04e5e) to head (f5a6444).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5854   +/-   ##
=======================================
  Coverage   98.50%   98.51%           
=======================================
  Files         395      395           
  Lines       38767    38782   +15     
=======================================
+ Hits        38188    38205   +17     
+ Misses        579      577    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 59edb09 into os-autoinst:master Aug 15, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants