-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend test coverage of OpenQA::Git #5854
Extend test coverage of OpenQA::Git #5854
Conversation
This was created as alternative approach to I recommend against moving more tests into that file as long as they do not rely on a test database |
d698970
to
e933443
Compare
4336ce2
to
d2bbe13
Compare
d2bbe13
to
0105b17
Compare
281af6a
to
a6b8654
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one style suggestion for next time
I guess we have to force merge this because of the broken circleci test Edit: @r-richardson fixed it |
a6b8654
to
f5a6444
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5854 +/- ##
=======================================
Coverage 98.50% 98.51%
=======================================
Files 395 395
Lines 38767 38782 +15
=======================================
+ Hits 38188 38205 +17
+ Misses 579 577 -2 ☔ View full report in Codecov by Sentry. |
Related Ticket: https://progress.opensuse.org/issues/164886