-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor git functionality into OpenQA::Git #5900
Refactor git functionality into OpenQA::Git #5900
Conversation
f3fd365
to
5b2fad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the method names:
In non object oriented code, it can be good to have functions with a common prefix, so it made sense to have git
prepended in the current version.
Now for a module that is called OpenQA::Git
and the object is called $git
, I think we can remove those prefixes.
e.g.
- my $origin_url = $git->git_get_origin_url;
+ my $origin_url = $git->get_origin_url;
589814a
to
1e74ff5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5900 +/- ##
=======================================
Coverage 98.71% 98.72%
=======================================
Files 394 394
Lines 38657 38672 +15
=======================================
+ Hits 38162 38180 +18
+ Misses 495 492 -3 ☔ View full report in Codecov by Sentry. |
1e74ff5
to
167e5b0
Compare
167e5b0
to
7a664f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving anyway to get things forward
e2a6dfe
to
0f87c0a
Compare
- Make path variable and ssh batch mode usage method parameters - Fix merge conflicts after rebase to master branch - Avoid array recreation with _run_cmd helper method - Minor fixes
0f87c0a
to
c2f1864
Compare
Refactor git related functions from OpenQA::Task::Git::Clone into the OpenQA::Git module for easier re-usability.
Related Ticket: 164886