Refactor git functionality into OpenQA::Git #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-richardson
force-pushed
the
refactor_use_openqa_git_MERGE_TEST
branch
2 times, most recently
from
f3fd365
to
5b2fad9
Compare
perlpunk
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Regarding the method names:
In non object oriented code, it can be good to have functions with a common prefix, so it made sense to have git prepended in the current version.
Now for a module that is called OpenQA::Git and the object is called $git, I think we can remove those prefixes.
e.g.
- my $origin_url = $git->git_get_origin_url;
+ my $origin_url = $git->get_origin_url;
perlpunk
reviewed
Aug 29, 2024
r-richardson
force-pushed
the
refactor_use_openqa_git_MERGE_TEST
branch
2 times, most recently
from
589814a
to
1e74ff5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5900 +/- ##
=======================================
Coverage 98.71% 98.72%
=======================================
Files 394 394
Lines 38657 38672 +15
=======================================
+ Hits 38162 38180 +18
+ Misses 495 492 -3 ☔ View full report in Codecov by Sentry. |
r-richardson
force-pushed
the
refactor_use_openqa_git_MERGE_TEST
branch
from
1e74ff5
to
167e5b0
Compare
perlpunk
reviewed
Aug 30, 2024
perlpunk
reviewed
Aug 30, 2024
b10n1k
reviewed
Aug 30, 2024
r-richardson
force-pushed
the
refactor_use_openqa_git_MERGE_TEST
branch
from
167e5b0
to
7a664f1
Compare
perlpunk
reviewed
Aug 30, 2024
perlpunk
approved these changes
Aug 30, 2024
perlpunk
reviewed
Aug 30, 2024
r-richardson
force-pushed
the
refactor_use_openqa_git_MERGE_TEST
branch
2 times, most recently
from
e2a6dfe
to
0f87c0a
Compare
- Make path variable and ssh batch mode usage method parameters - Fix merge conflicts after rebase to master branch - Avoid array recreation with _run_cmd helper method - Minor fixes
r-richardson
force-pushed
the
refactor_use_openqa_git_MERGE_TEST
branch
from
0f87c0a
to
c2f1864
Compare
b10n1k
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor git related functions from OpenQA::Task::Git::Clone into the OpenQA::Git module for easier re-usability.
Related Ticket: 164886