Add missing flash message box to /tests page #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page can have flash messages created by ajax events.
kalikiana
approved these changes
Sep 12, 2024
The last part let's me wonder. For flash messages created by ajax handlers we don't need to include the layout that will add flash messages from server-side stash variables. So maybe we can just add the div here without including the layout. |
|
Sure we could do that. But I prefer to not have two different flash snippets around where some pages then support serverside flash messages and some only support client side messages. |
okurz
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page can have flash messages created by ajax events.