Replace $.ajax() with fetch() #5925
Conversation
asdil12
force-pushed
the
fetch
branch
6 times, most recently
from
e838560
to
9aed887
Compare
| @@ -23,6 +23,16 @@ function setupForAll() { | |||
| }); | |||
| } | |||
|
|
|||
| function getCSRFToken() { | |||
| return document.querySelector('meta[name="csrf-token"]').content; | |||
There was a problem hiding this comment.
Maybe it makes more sense to give this element an ID and use document.getElementById.
asdil12
force-pushed
the
fetch
branch
3 times, most recently
from
9f07f1a
to
0c65ba6
Compare
|
Looks generally good so from my side you could go ahead and change more places this way. |
asdil12
force-pushed
the
fetch
branch
13 times, most recently
from
4bc8f1a
to
7e08662
Compare
asdil12
force-pushed
the
fetch
branch
3 times, most recently
from
b507723
to
68bc207
Compare
asdil12
force-pushed
the
fetch
branch
3 times, most recently
from
5e63cd6
to
5a2adfb
Compare
There was a problem hiding this comment.
There is still one open inline-comment: https://github.com/os-autoinst/openQA/pull/5925/files#r1775493947
Otherwise this change is good to merge if tests are passing.
|
I know it's bad but this line needs to be marked as uncoverable (despite you have already marked the statement as uncoverable): https://app.codecov.io/gh/os-autoinst/openQA/pull/5925/blob/t/lib/OpenQA/SeleniumTest.pm#L149 Maybe it makes also sense to use |
|
@Martchus done - let's hope that I don't have to add an |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
|
Please merge when you can monitor |
| @@ -171,8 +175,9 @@ function updateTestStatus(newStatus) { | |||
| reloadBrokenThumbnails(true); | |||
| } | |||
| }) | |||
| .fail(function () { | |||
| .catch(error => { | |||
| console.log('ERROR: modlist fail'); | |||
There was a problem hiding this comment.
Do you need this as there is a console.error in the next line?
There was a problem hiding this comment.
It is good to see where it failed and afterwards also what the error was.
|
The coverage check still fails because |
Ticket: https://progress.opensuse.org/issues/166310 Co-authored-by: Martchus <[email protected]>
|
Rebased |
Co-authored-by: Martchus <[email protected]>
Ticket: https://progress.opensuse.org/issues/166310