Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the error responsible for API failures is always added #5927

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

Martchus
Copy link
Contributor

So far the "last error" was only tracked for REST-API calls (used e.g. for worker registration and uploads) but not in other cases (e.g. web socket related errors). This change extends tracking for to cover those cases by setting the last error to the error messages that is always passed to _set_status. This way they are available to be added to the reason when declaring the job as incomplete.

Related ticket: https://progress.opensuse.org/issues/163781

So far the "last error" was only tracked for REST-API calls (used e.g. for
worker registration and uploads) but not in other cases (e.g. web socket
related errors). This change extends tracking for to cover those cases by
setting the last error to the error messages that is always passed to
`_set_status`. This way they are available to be added to the reason when
declaring the job as incomplete.

Related ticket: https://progress.opensuse.org/issues/163781
@kalikiana
Copy link
Member

[15:02:28] t/ui/10-tests_overview.t ................... 10/? 
        #   Failed test '#flavor_DVD_arch_i586 present exactly once'
        #   at /home/squamata/project/t/ui/../lib/OpenQA/SeleniumTest.pm line 237.
        #          got: '0'
        #     expected: '1'

        #   Failed test '#flavor_DVD_arch_i586 exists'
        #   at /home/squamata/project/t/ui/../lib/OpenQA/SeleniumTest.pm line 240.
        # Looks like you failed 2 tests of 8.

    #   Failed test 'filter for specific archs'
    #   at t/ui/10-tests_overview.t line 259.
    # Looks like you failed 1 test of 2.

@perlpunk
Copy link
Contributor

https://progress.opensuse.org/issues/166820 t/ui/10-tests_overview.t

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (b54d8ce) to head (d5f4359).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5927      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         395      395              
  Lines       38766    38768       +2     
==========================================
- Hits        38277    38276       -1     
- Misses        489      492       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 1b03f55 into os-autoinst:master Sep 14, 2024
45 checks passed
@Martchus Martchus deleted the worker-client-last-error branch September 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants