Fix quoting of git ssh arguments #5947
Conversation
|
I tested this locally |
| @@ -32,7 +32,7 @@ sub _run_cmd ($self, $args, $options = {}) { | |||
| my $include_git_path = $options->{include_git_path} // 1; | |||
| my $ssh_batchmode = $options->{ssh_batchmode} // 0; | |||
| my @cmd; | |||
| push @cmd, 'env', 'GIT_SSH_COMMAND="ssh -oBatchMode=yes"' if $ssh_batchmode; | |||
| push @cmd, 'env', 'GIT_SSH_COMMAND=ssh -oBatchMode=yes' if $ssh_batchmode; | |||
There was a problem hiding this comment.
Can we have unit test coverage for this?
There was a problem hiding this comment.
I thought about it, but no good idea yet.
e.g. if we actually ran git on temporary git repositories created during unit tests, that would be an improvement, but we would use local git repositories in paths, not remote ones, I guess, so the ssh ... stuff would never be called.
Ideas welcome.
In any case, we should deploy this fix.
|
ok, I need to fix the tests of course. edit: pushed |
Error detecting remote default branch name for "some git":
"ssh -oBatchMode=yes": ssh -oBatchMode=yes: command not found
Since we are passing an array ref to IPC::Run::run, we should not add quotes.
git is trying to call `"ssh ..."` including the quotes.
Issues:
* https://progress.opensuse.org/issues/164898
* https://progress.opensuse.org/issues/164886
perlpunk
force-pushed
the
fix-git-ssh-cmd
branch
from
fd38c0e
to
9bc1ffa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5947 +/- ##
=======================================
Coverage 98.74% 98.75%
=======================================
Files 396 396
Lines 38967 38967
=======================================
+ Hits 38479 38482 +3
+ Misses 488 485 -3 ☔ View full report in Codecov by Sentry. |
Since we are passing an array ref to IPC::Run::run, we should not add quotes. git is trying to call
"ssh ..."including the quotes.Issues: