Improve OpenID auth handling on not_openid response #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksinger
reviewed
Sep 26, 2024
perlpunk
reviewed
Sep 26, 2024
b10n1k
force-pushed
the
167266_not_openid
branch
from
2d8be5c
to
67549de
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
b10n1k
force-pushed
the
167266_not_openid
branch
2 times, most recently
from
06f453e
to
76f7884
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5952 +/- ##
=======================================
Coverage 98.75% 98.76%
=======================================
Files 396 396
Lines 38983 38991 +8
=======================================
+ Hits 38499 38510 +11
+ Misses 484 481 -3 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
b10n1k
force-pushed
the
167266_not_openid
branch
from
76f7884
to
40371f2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b10n1k
force-pushed
the
167266_not_openid
branch
7 times, most recently
from
7d75325
to
4e21c9d
Compare
okurz
reviewed
Sep 30, 2024
b10n1k
force-pushed
the
167266_not_openid
branch
from
4e21c9d
to
c6cc29a
Compare
okurz
requested changes
Oct 1, 2024
b10n1k
force-pushed
the
167266_not_openid
branch
from
c6cc29a
to
11e55fa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b10n1k
force-pushed
the
167266_not_openid
branch
2 times, most recently
from
737dd8c
to
fcc5b2d
Compare
okurz
reviewed
Oct 2, 2024
Enhanced error handling by including OpenID provider URI in error messages for invalid data. The error seems sporadic and as part of the research on https://progress.opensuse.org/issues/167266 we can consider this not a severe problem. Because of the sensitivity of the arguments, it is not feasible to add any info from the available data for later debbugging. But at least now we can tell which server cause problems. Signed-off-by: Ioannis Bonatakis <[email protected]>
b10n1k
force-pushed
the
167266_not_openid
branch
from
fcc5b2d
to
8ce5afe
Compare
b10n1k
changed the title
okurz
requested changes
Oct 2, 2024
Comment on lines
+47
to
+53
| $c->set_always( | ||
| req => Test::MockObject->new->set_always( | ||
| params => Test::MockObject->new->set_always(pairs => ['openid.op_endpoint', 'https://www.opensuse.org/openid/']) | ||
| )->set_always(url => Test::MockObject->new->set_always(base => 'openqa'))) | ||
| ->set_always( | ||
| app => Test::MockObject->new->set_always(config => {})->set_always(log => Test::MockObject->new->set_true('debug'))) | ||
| ->set_true('flash'); |
There was a problem hiding this comment.
can you reduce the duplication here?
There was a problem hiding this comment.
I tried. but I didnt find a way. I couldnt just change the set_always(log => Test::MockObject->new->set_true('debug'))
There was a problem hiding this comment.
I can leave it as it was but this was confusing to me. tests produces positive negatives. for instance:
if I replace error with debug in https://github.com/os-autoinst/openQA/pull/5952/files#diff-dc3d35214db1365be81906f2eabbaae8a531b3ab984c06eff8fd425f3cb40f2dR37 still works, it was before.
okurz
approved these changes
Oct 2, 2024
baierjan
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced error handling by including OpenID provider URI in error messages for
invalid data. The error seems sporadic and as part of the research on
https://progress.opensuse.org/issues/167266 we can consider this not a severe
problem. Because of the sensitivity of the arguments, it is not feasible to
add any info from the available data for later debbugging. But at least now
we can tell which server cause problems.