Decrease log level from warn to info for git clone reject #5956
Conversation
lib/OpenQA/Task/Git/Clone.pm
Outdated
| @@ -65,7 +65,7 @@ sub _git_clone ($app, $job, $ctx, $path, $url) { | |||
|
|
|||
| my $origin_url = $git->get_origin_url; | |||
| if ($url ne $origin_url) { | |||
| $ctx->warn("Local checkout at $path has origin $origin_url but requesting to clone from $url"); | |||
| $ctx->info("Local checkout at $path has origin $origin_url but requesting to clone from $url"); | |||
There was a problem hiding this comment.
Can you rephrase the message to make the "so what" clear?
There was a problem hiding this comment.
Is this actionable? My understanding from the ticket is this works as expected. So I would actually say remove it.
There was a problem hiding this comment.
This can be helpful without being actionable, e.g. when debugging and trying to make sense of what our Git code does or skips.
|
webui-docker-compose fail is due to https://progress.opensuse.org/issues/167524 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5956 +/- ##
==========================================
- Coverage 98.75% 98.75% -0.01%
==========================================
Files 396 396
Lines 38966 38966
==========================================
- Hits 38482 38479 -3
- Misses 484 487 +3 ☔ View full report in Codecov by Sentry. |
asdil12
force-pushed
the
info
branch
2 times, most recently
from
3a5e4af
to
1a0f944
Compare
asdil12
force-pushed
the
info
branch
2 times, most recently
from
5a90a6e
to
a784731
Compare
Ticket: https://progress.opensuse.org/issues/167386