Improve minion guards for needle tasks

[perlpunk]

In OpenQA::Task::Needle::Save, OpenQA::Task::Needle::Delete and
OpenQA::Task::Git::Clone we are now using a guard for the individual directory
git_clone_${needledir}_task instead of a global guard limit_needle_task.

Issue: https://progress.opensuse.org/issues/164898

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (9d29acb) to head (015e115).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5961      +/-   ##
==========================================
- Coverage   98.78%   98.77%   -0.01%     
==========================================
  Files         396      396              
  Lines       39023    39043      +20     
==========================================
+ Hits        38547    38564      +17     
- Misses        476      479       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Martchus]

We probably need the same for the delete needle task. But otherwise it looks good.

[perlpunk]

We probably need the same for the delete needle task.

why?

[Martchus]

Because it also invokes Git commands on a needle checkout (so far only using the limit_needle_task lock).

[perlpunk]

Because it also invokes Git commands on a needle checkout (so far only using the limit_needle_task lock).

Oh, the git operation is hidden in OpenQA::Schema::Result::Needles. I only looked at OpenQA::Task::Needle::Delete and didn't expect it elsewhere :(

[okurz]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[perlpunk]

I updated all git gru tasks to use a guard per directory instead of the global one

[perlpunk]

There seems to be flaky coverage in lib/OpenQA/Shared/Controller/Running.pm. We don't see it because the coverage decrease is so low, but going to the report I can see it in the indirect changes tab often:

     # setup a function to stop streaming again
     my $timer_id;
     my $close_connection = sub ($self, @) {     # line 204-206 reported as uncovered
         Mojo::IOLoop->remove($timer_id);
         $self->finish;
     };
 
     # setup a recurring timer to send the last screenshot to the client

edit: https://progress.opensuse.org/issues/167803

Resolved