-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for structured variables on the scheduled product page #5972
Allow for structured variables on the scheduled product page #5972
Conversation
7fd1a32
to
5be4fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix your commit that still says "WIP"
And could you provide a screenshot so we can see how it looks like when one has such "structured variables" on a product? |
5d46779
to
8c39e72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you put into the description of the pull request could also be in the commit message details. I don't know how you created your pull request but your git commit messages has only the subject line while the pull request description has more details. Please keep in mind that the github pull request description is only visible on github, the commit can be considered permanent information storage.
I can recommend the tool hub (zypper in rubygem-hub) for easier PR creation. Also, I myself use a script git-pr-last to create a PR with proper description for these simple one-commit PRs:
$ cat $(which git-pr-last )
#!/bin/sh -e
target="${target:-"$USER"}"
git push $target && git show --no-patch --format=%B | hub pull-request -F -
You might want to use the more up-to-date tool https://github.com/cli/cli
See https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/CONTRIBUTING.md#coding-style for more details
3594b25
to
fac83e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested. they are calisthenic touches and nothing to do with the logic. Just following some good practices. thank you man and let me know if you have objections
fac83e8
to
527e933
Compare
@b10n1k "calisthenic touches" as in https://en.wikipedia.org/wiki/Calisthenics ? This seems highly unrelated :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I just noticed that I missed to press the comment button or something in the morning and one of my comments was missing.
This commit fixes the scheduled product page loading issues, which occur when job settings contain arrays. Related ticket: https://progress.opensuse.org/issues/166154
527e933
to
7fe6d83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5972 +/- ##
==========================================
- Coverage 98.75% 98.75% -0.01%
==========================================
Files 396 396
Lines 38984 38984
==========================================
- Hits 38500 38497 -3
- Misses 484 487 +3 ☔ View full report in Codecov by Sentry. |
This PR fixes the scheduled product page loading issues, which occur when job settings contain arrays, mentioned in https://progress.opensuse.org/issues/166154
example: