Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "OpenQA::WebAPI::Plugin::HashedParams" #5994

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Drop "OpenQA::WebAPI::Plugin::HashedParams" #5994

merged 1 commit into from
Oct 22, 2024

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Oct 9, 2024

Reverts #5993

@asdil12 asdil12 changed the title Drop OpenQA::WebAPI::Plugin::HashedParams" Drop "OpenQA::WebAPI::Plugin::HashedParams" Oct 9, 2024
@okurz
Copy link
Member

okurz commented Oct 9, 2024

To be merged when client changes are available for more downstream users

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (cd422ea) to head (994a3e2).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5994      +/-   ##
==========================================
+ Coverage   98.83%   98.85%   +0.02%     
==========================================
  Files         396      395       -1     
  Lines       39187    39150      -37     
==========================================
- Hits        38730    38702      -28     
+ Misses        457      448       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@os-autoinst os-autoinst deleted a comment from mergify bot Oct 11, 2024
@asdil12
Copy link
Member Author

asdil12 commented Oct 11, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Oct 11, 2024

rebase

✅ Branch has been successfully rebased

Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request is now in conflicts. Could you fix it? 🙏

@kalikiana
Copy link
Member

So that's poo#64412 I guess

@asdil12 asdil12 removed the not-ready label Oct 22, 2024
@mergify mergify bot merged commit 9a22ad5 into master Oct 22, 2024
51 checks passed
@mergify mergify bot deleted the revert-5993-r1 branch October 22, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants