Enable perlcritic checks in CI

Run perlcritic against all the perl git files. https://progress.opensuse.org/issues/138416 Signed-off-by: ybonatakis <[email protected]>
os-autoinst · Feb 12, 2024 · a131cb3 · a131cb3
1 parent 10683a4
commit a131cb3
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/.github/workflows/check_critic.yml b/.github/workflows/check_critic.yml
@@ -0,0 +1,13 @@
+---
+name: perlcritic
+on: [push, pull_request]
+
+jobs:
+  perlcritic_checks:
+    runs-on: ubuntu-latest
+    container:
+      image: registry.opensuse.org/devel/openqa/containers/os-autoinst_dev
+    steps:
+      - uses: actions/checkout@v4
+      - name: Static analysis
+        run: ./external/os-autoinst-common/tools/perlcritic --quiet .
diff --git a/.perlcriticrc b/.perlcriticrc
@@ -0,0 +1 @@
+external/os-autoinst-common/.perlcriticrc
diff --git a/main.pm b/main.pm
@@ -1,7 +1,8 @@
 # Copyright 2014-2018 SUSE LLC
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-use strict;
+
+use Mojo::Base -strict;
 use testapi;
 use autotest;
 

diff --git a/tests/boot.pm b/tests/boot.pm
@@ -1,8 +1,7 @@
 # Copyright 2014-2018 SUSE LLC
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-use base 'basetest';
-use strict;
+use Mojo::Base 'basetest';
 use testapi;
 
 sub run {