Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align example distribution with openqa docs & best practices #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Align example distribution with openqa docs & best practices #30

wants to merge 1 commit into from

Conversation

josegomezr
Copy link
Contributor

  • Align tests/boot.pm with the documentation. It should use Mojo::Base as the docs state.

  • Add use strict/warnings for non-Mojo::Base modules (main.pm).

poo#138416

@josegomezr
Align example distribution with openqa docs & best practices
75a1b5d 
- Align `tests/boot.pm` with the documentation. It should
  `use Mojo::Base` as the docs state.

- Add `use strict/warnings` for non-`Mojo::Base` modules
  (`main.pm`).
@josegomezr josegomezr mentioned this pull request Dec 20, 2023
Merged
@okurz
Copy link
Member

okurz commented Dec 20, 2023

Looks good. I just did the corresponding change in

as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martchus Martchus Martchus approved these changes

@okurz okurz okurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josegomezr @okurz @Martchus