Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable perlcritic checks in CI #37

Merged
merged 1 commit into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/check_critic.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
name: perlcritic
on: [push, pull_request]

jobs:
perlcritic_checks:
runs-on: ubuntu-latest
container:
image: registry.opensuse.org/devel/openqa/containers/os-autoinst_dev
steps:
- uses: actions/checkout@v4
- name: Static analysis
run: ./external/os-autoinst-common/tools/perlcritic --quiet .
1 change: 1 addition & 0 deletions .perlcriticrc
3 changes: 2 additions & 1 deletion main.pm
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Copyright 2014-2018 SUSE LLC
# SPDX-License-Identifier: GPL-2.0-or-later

use strict;

use Mojo::Base -strict;
use testapi;
use autotest;

Expand Down
3 changes: 1 addition & 2 deletions tests/boot.pm
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# Copyright 2014-2018 SUSE LLC
# SPDX-License-Identifier: GPL-2.0-or-later

use base 'basetest';
use strict;
use Mojo::Base 'basetest';
use testapi;

sub run {
Expand Down
Loading