Enable yaml checks in CI #39
Conversation
.github/workflows/yaml-checks.yml
Outdated
| - name: Validate yamls | ||
| run: | | ||
| git config --global --add safe.directory '*' | ||
| yamllint --strict $(git ls-files "*.yml" "*.yaml" 2> /dev/null || find . -name '*.y*ml') |
There was a problem hiding this comment.
This would be good to have in a makefile, or script or wherever currently style checks for this repo are defined. So one can do 'make check' or sth and include this and other checks
There was a problem hiding this comment.
But there is not a makefile on this repo!
There was a problem hiding this comment.
I suggest to create one then, like in os-autoinst-common :)
Also you could do the same as what @okurz adds to the Makefile in os-autoinst/os-autoinst-common#49
b10n1k
force-pushed
the
add_yaml_check
branch
from
8cade01
to
b40d5d3
Compare
.github/workflows/yaml-checks.yml
Outdated
| - name: Validate yamls | ||
| run: | | ||
| git config --global --add safe.directory '*' | ||
| yamllint --strict $(git ls-files "*.yml" "*.yaml" 2> /dev/null || find . -name '*.y*ml') |
There was a problem hiding this comment.
Please use yamllint as already mentioned in the other PR:
https://github.com/os-autoinst/os-autoinst-common/blob/master/.github/workflows/yamllint.yml
You don't need to pass it the list of files, it will by default lint .yml and .yaml
b10n1k
force-pushed
the
add_yaml_check
branch
2 times, most recently
from
710cdd7
to
62e0d33
Compare
b10n1k
force-pushed
the
add_yaml_check
branch
5 times, most recently
from
bb5e806
to
2581749
Compare
Signed-off-by: ybonatakis <[email protected]>
b10n1k
force-pushed
the
add_yaml_check
branch
from
2581749
to
da70f49
Compare
No description provided.