Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[virtualization][MU]: Set PATCH_WITH_ZYPPER and UPDATE_PACKAGE in code #19733

Merged

Conversation

alice-suse
Copy link
Contributor

@alice-suse alice-suse commented Jul 15, 2024

This PR mainly does below:

  • use var BUILD info to set UPDATE_PACKAGE in main.pm, BUILD format eg BUILD=:33310:dtb-armv7l -- :: (libvirt pkg needs value translation)
  • PATCH_WITH_ZYPPER, set to 1 for official test, and allow customized value 0 if passing down by user

Related ticket: A4 task openqa part, https://progress.opensuse.org/issues/160856

Note: this PR shall be merged together with https://progress.opensuse.org/issues/160859

Verification run:

verification run on http://10.67.129.77/

Unit test:
PASS: qemu pkg
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="15-SP5" FLAVOR=Server-DVD-Virt-KVM-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-kvm-migration-src,qam-kvm-migration-dst BUILD=":123456:qemu"
{"count":2,"failed":[],"ids":[769,770],"scheduled_product_id":315}

PASS: xen pkg
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="15-SP5" FLAVOR=Server-DVD-Virt-XEN-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-xen-migration-src,qam-xen-migration-dst BUILD=":123456:xen"
{"count":2,"failed":[],"ids":[777,778],"scheduled_product_id":316}

PASS: libvirt pkg
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="15-SP5" FLAVOR=Server-DVD-Virt-KVM-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-kvm-migration-src,qam-kvm-migration-dst BUILD=":123456:libvirt"
{"count":2,"failed":[],"ids":[779,780],"scheduled_product_id":321}

PASS: kernel-default pkg, trigger value `"BUILD" : ":123456:dtb-armv7l"`
http://10.67.129.77/tests/749/file/vars.json


PATCH_WITH_ZYPPER
- default 1: good
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="12-SP5" FLAVOR=Server-DVD-Virt-XEN-GuestMigration-Incidents TERADATA= GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-xen-migration-src,qam-xen-migration-dst BUILD=":123456:xen"
{"count":2,"failed":[],"ids":[763,764],"scheduled_product_id":312}

- customized 0: good
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="12-SP5" FLAVOR=Server-DVD-Virt-XEN-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-xen-migration-src,qam-xen-migration-dst BUILD=":123456:xen"
{"count":2,"failed":[],"ids":[765,766],"scheduled_product_id":313}



Verification runs on OSD for vmware&hyperv :
- 15sp3 hyperv kernel pkg: https://openqa.suse.de/tests/15304805/file/vars.json (commented off the check of the updated pkg installed from TEST_X repo)
- 15sp4 vmware TERADATA, open-vm-tools pkg: https://openqa.suse.de/tests/15304809/file/vars.json (commented off the check of the updated pkg installed from TEST_X repo)


A3,A4 together, full verification jobs:

PASS
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="15-SP5" FLAVOR=Server-DVD-Virt-KVM-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-kvm-migration-src,qam-kvm-migration-dst BUILD=":123456:qemu"
{"count":2,"failed":[],"ids":[769,770],"scheduled_product_id":315}

PASS
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="15-SP5" FLAVOR=Server-DVD-Virt-XEN-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-xen-migration-src,qam-xen-migration-dst BUILD=":123456:xen"
{"count":2,"failed":[],"ids":[777,778],"scheduled_product_id":316}

PASS
qa2-dhcp-77:/var/lib/openqa/tests/sle # openqa-cli api  -X POST isos ARCH="x86_64" DISTRI="sle" VERSION="15-SP5" FLAVOR=Server-DVD-Virt-KVM-GuestMigration-Incidents TERADATA=  PATCH_WITH_ZYPPER=0  GUEST_ADMINISTRATION=0 INTERVAL_LOG=0 TEST=qam-kvm-migration-src,qam-kvm-migration-dst BUILD=":123456:libvirt"
{"count":2,"failed":[],"ids":[779,780],"scheduled_product_id":321}

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@alice-suse alice-suse changed the title [wip][virtualization][MU]: Set PATCH_WITH_ZYPPER and UPDATE_PACKAGE in code [virtualization][MU]: Set PATCH_WITH_ZYPPER and UPDATE_PACKAGE in code Jul 15, 2024
@alice-suse
Copy link
Contributor Author

@RoyCai7 @tbaev @martinsmarcelo @waynechen55 @Julie-CAO Hello guys, welcome to review!

@RoyCai7
Copy link
Contributor

RoyCai7 commented Jul 23, 2024

LGTM

lib/main_common.pm Outdated Show resolved Hide resolved
@alice-suse alice-suse force-pushed the alice/mu-adopt-ci-in-sles-A4 branch 2 times, most recently from 5919e31 to 7385b41 Compare August 30, 2024 07:31
@RoyCai7
Copy link
Contributor

RoyCai7 commented Aug 30, 2024

LGTM for hyperv and vmware change.

@alice-suse
Copy link
Contributor Author

The schedule_issue.py PR is also ready, let's merge them together.

@alice-suse alice-suse merged commit 1499a65 into os-autoinst:master Sep 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants