Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sles4sap hanasr delayedcrash #20184

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpagot
Copy link
Contributor

@mpagot mpagot commented Sep 12, 2024

Verification run:

sle-15-SP6-HanaSr-Aws-Byos-x86_64-Build15-SP6_2024-09-27T02:03:13Z-hanasr_aws_test_fencing_sbd_crash ec2_r4.8xlarge

sle-15-SP6-HanaSr-Azure-Byos-x86_64-Build15-SP6_2024-09-11T02:03:14Z-hanasr_azure_test_saptune_msi@az_Standard_E4s_v3

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@mpagot mpagot added WIP Work in progress qe-sap-ha labels Sep 12, 2024
@mpagot mpagot marked this pull request as draft September 12, 2024 16:39
@mpagot mpagot force-pushed the sles4sap_hanasr_delayedcrash branch 6 times, most recently from 130a755 to 2286c57 Compare September 13, 2024 16:19
Copy link
Contributor

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. LGTM

One of the HanaSR test is about crashing one cluster node running HANA.
Crash command is executed through a ssh channel. Problem is that, as soon as the
system crash, the ssh connection  is interrupted leaving the ssh client blocked.
The idea is: compose the remotely executed command with a sleep and then the crash,
run these two in background. It gives time to the ssh client to close the
session before the crash happening.
Remove the timepout=0 behavior, stop forwarding to run_ssh_command all
the args content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-sap-ha WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants