Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wicked: test dummy interfaces #20186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tacerus
Copy link

@tacerus tacerus commented Sep 12, 2024

Add test coverage to assess whether dummy interfaces get created successfully using either one of the three supported declaration routes to detect issues such as boo#1229555 early.

  • Related ticket: n/a
  • Needles: n/a
  • Verification run: tbd

@tacerus tacerus force-pushed the wicked-dummy branch 2 times, most recently from 16e49c5 to 899ed16 Compare September 12, 2024 23:54
Add test coverage to assess whether dummy interfaces get created
successfully using either one of the three supported declaration routes
to detect issues such as boo#1229555 early.

Signed-off-by: Georg Pfuetzenreuter <[email protected]>
@tacerus
Copy link
Author

tacerus commented Sep 13, 2024

Originally I had it in tests/wicked/startandstop/sut/ which sounded like a better place, but that suite seems to have some preliminary problems https://openqa.opensuse.org/tests/4475586#step/t01_gre_tunnel_legacy/9?
Hence I placed it in tests/wicked/basic/sut/, but there I have some issue with barriers: https://openqa.opensuse.org/tests/4475599#step/t23_dummy_ifup_ifreload/8.
Any ideas?

@cfconrad
Copy link
Contributor

cfconrad commented Sep 13, 2024

Thanks a lot for heads up and taking action!

The problem with the barrier is, that you parallel job doesn't have the CASEDIR set, thus the barrier for that corresponding test is not running.
If you did it with openqa-clone-job use the parameter --parental-inheritance.

I also took some time to create a test for config parsing... But I didn't submitted till now, as the fix wasn't available. I think creating such thing as a draft would be better for the next time! Plz take a look at #20193 and let's see with what kind of test we wanna continue.

@tacerus
Copy link
Author

tacerus commented Sep 13, 2024

Thank you for the explanation and hint about --parental-inheritance, I'll remember that next time.

Indeed, a draft PR would be useful, I was checking there if someone worked on this already. ;-) But not a problem, happy to see you already having thought of it. Your solution seems to cover more scenarios, so might be a better fit than mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants