[PublicCloud] Skip validate repo on SLEM 6+ #20229
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimi1vx
requested review from
pdostal,
grisu48,
asmorodskyi,
ricardobranco777,
mpagot,
m-dati,
alvarocarvajald and
BillAnastasiadis
as code owners
grisu48
reviewed
Sep 19, 2024
| @@ -146,6 +146,10 @@ sub register_openstack { | |||
| # Validation for update repos | |||
| sub validate_repo { | |||
| my ($maintrepo) = @_; | |||
| if (is_sle_micro('>=6.0')) { | |||
| record_info("NEW MAINT MODE", "New style update, so can't validate repository"); | |||
There was a problem hiding this comment.
Do we really want one info box per repository?
There was a problem hiding this comment.
on SL Micro 6 its only one repo anyway
grisu48
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
LGTM as per https://suse.slack.com/archives/C02CLB8TZP1/p1726743970046109?thread_ts=1726741239.519879&cid=C02CLB8TZP1 but one minor nitpick
jlausuch
reviewed
Sep 19, 2024
| @@ -146,6 +146,10 @@ sub register_openstack { | |||
| # Validation for update repos | |||
| sub validate_repo { | |||
| my ($maintrepo) = @_; | |||
| if (is_sle_micro('>=6.0')) { | |||
| record_info("NEW MAINT MODE", "New style update, so can't validate repository"); | |||
There was a problem hiding this comment.
The message sounds a bit confusing for whom does not know about this. Maybe something like "Skip repo validation. Embargoed updates are not pushed in SL Micro 6+." or something similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.