-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Virtualization]: Add update_nvram for uefi autoyast installation #20251
Open
alice-suse
wants to merge
21
commits into
os-autoinst:master
Choose a base branch
from
alice-suse:alice/survive_vt_test_with_other_secureboot_tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP][Virtualization]: Add update_nvram for uefi autoyast installation #20251
alice-suse
wants to merge
21
commits into
os-autoinst:master
from
alice-suse:alice/survive_vt_test_with_other_secureboot_tests
+63
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-suse
force-pushed
the
alice/survive_vt_test_with_other_secureboot_tests
branch
from
September 27, 2024 07:51
f2e3bb1
to
9564f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve the problem in https://progress.opensuse.org/issues/166712#note-23, for which if a job with secure boot enabled is installed onto a disk, that is different from the disk that our virtualization jobs will install on(for both sles and sle micro), the installed virtualization host OS will not boot successfully.
Solution is to erase disks before real installation starts:
for sles, add in autoyast pre-script the disk erasing script
for sle micro, at ipxe_install, call prepare_disks
Related ticket: https://progress.opensuse.org/issues/166712
Verification run: