Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to bare metal for direct image installation of SL Micro #20253
Add support to bare metal for direct image installation of SL Micro #20253
Changes from all commits
d034bc9
b893a42
95a90cc
667b577
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ever confirmed with SLM project managers that SLE Micro only supports uefi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter at all, especially for kernel testing where we have more legacy machines than in uefi mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really?
How many machines relevant today cannot do EFI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not quite agree . It will brings invalid test results, I think. @jlausuch HDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also shouldn't EFI provide a mechanism for thekernel to get the actual console set up in the BIOS?
Even if it's not the case it would be much more reasonable get the console settings from the commandline of the runnig kernel rather than hardcoding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is specific part is in the newly introduced .pm module, so personally I see no reason to block the merge.
We could improve handling of this parameter and we could make it in a way that the test run could change the behavior, but this could be done later when it is needed and by folks who needed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded console settings are directly in image produced by ibs. If you think it is not right, feel free to file a bug or create jira for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are, however, additional hardcoded setting in this test, separate from settings hardcoded in the image.
The value with which the settings are replaced could be taken from the commandline of the running kernel which can in turn be adjusted in the test setup making it easier to adjust console settings for the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, but console of running kernel is already configured by the test in ipxe boot script from variable IPXE_CONSOLE. Follow up ticket for this change was already created and is mentioned on other comments in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://progress.opensuse.org/issues/167608