-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudregistration test module improvements #20260
Cloudregistration test module improvements #20260
Conversation
CI claiming tidy needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
901a9d0
to
7eee83a
Compare
use version_utils 'is_sle'; | ||
|
||
my $path = is_sle('=15-SP2') ? '/usr/sbin/' : ''; # 15-SP2 is the oldest version that needs fullpaths | ||
my $regcode_param = (is_byos()) ? "-r " . get_required_var('SCC_REGCODE') : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a discussion with @asmorodskyi, that is the intended behavior and has worked like that so far. I am just removing one of the checks as it is impossible due to us not supporting versions that old.
@@ -19,7 +19,9 @@ use strict; | |||
use utils; | |||
use publiccloud::utils; | |||
use publiccloud::ssh_interactive 'select_host_console'; | |||
use version_utils 'is_sle'; | |||
|
|||
my $path = is_sle('=15-SP2') ? '/usr/sbin/' : ''; # 15-SP2 is the oldest version that needs fullpaths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the comment, # 15-SP2 is the oldest version that needs fullpaths
i.e. No other version needs the fullpath, so no need to use it.
ce1f098
to
96b5145
Compare
657d1df
to
ca9e91c
Compare
ca9e91c
to
9c00e63
Compare
We have a list of manual steps which are executed to verify cloud-regionsrv-client. The steps can be found here: https://github.com/SUSE-Enceladus/cloud-regionsrv-client/blob/master/integration_test-process.txt
Our existing automated tests did not cover all of the steps listed so this PR aims to remedy that.
This PR:
use version_utils 'is_sle';
)ls /etc/zypp/credentials.d/ | wc -l
vsls -A /etc/zypp/credentials.d/
.Additional info:
Verification runs: