Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfstests: Fix match grub failed after reset #20272

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

SeroSun
Copy link
Member

@SeroSun SeroSun commented Sep 25, 2024

After resetting the system, if it directly goes into the login screen, we do not need to wait to match the grub page in wait_boot. To fix poo#167347.

  1. https://openqa.suse.de/tests/15700091#step/xfs-009/38
    Checkpoint: to check if xfs/009 keep running and pass after xfs/008 crashed(test fail is expected), compare with previous fail https://openqa.suse.de/tests/15640564#step/xfs-009/1.
  2. https://openqa.suse.de/tests/15700624#step/generic-300/2 (these test need to set QEMU_DISABLE_SNAPSHOTS=0 because it has QEMU_DISABLE_SNAPSHOTS=1 before), compare with previous fail https://openqa.suse.de/tests/15640463#step/generic-300/1
  3. Verification run for nfs case: https://openqa.suse.de/tests/15700755
    compare with previous fails https://openqa.suse.de/tests/15519040#step/generic-371/1
  4. Verification run for public cloud: https://openqa.suse.de/tests/15711503

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@SeroSun SeroSun force-pushed the yosun/fix_subtest_login branch 4 times, most recently from 81d85d8 to 1a2ccb3 Compare September 26, 2024 08:50
@SeroSun SeroSun changed the title xfstests: Fix match grub failed after reset [WIP]xfstests: Fix match grub failed after reset Sep 26, 2024
@SeroSun SeroSun force-pushed the yosun/fix_subtest_login branch 9 times, most recently from 21e9bd0 to 0322c73 Compare September 29, 2024 09:18
@SeroSun SeroSun force-pushed the yosun/fix_subtest_login branch 6 times, most recently from 0492a17 to b9004f8 Compare October 16, 2024 08:11
@SeroSun SeroSun changed the title [WIP]xfstests: Fix match grub failed after reset xfstests: Fix match grub failed after reset Oct 16, 2024
@SeroSun SeroSun force-pushed the yosun/fix_subtest_login branch 4 times, most recently from 2b33e98 to 9bedfcd Compare October 16, 2024 10:27
@lansuse
Copy link
Contributor

lansuse commented Oct 17, 2024

LGTM

- After reset if directly goes into login page will no need to wait to
match grub page in wait_boot.
- Remove /tmp before copy_log and reboot, to solve no-space-left error
to make reboot signal can't success.
- To fix poo#167347, copy_all_log part will not umount and mount if test
in unstable status and in nfs test.
- Add milestone in run.pm as snapshot rollback point.
@SeroSun SeroSun merged commit c232fe9 into os-autoinst:master Oct 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants