Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

velociraptor test cleanup #20299

Merged
merged 1 commit into from
Oct 8, 2024
Merged

velociraptor test cleanup #20299

merged 1 commit into from
Oct 8, 2024

Conversation

gosipyan
Copy link
Contributor

@gosipyan gosipyan commented Sep 27, 2024 •
edited
Loading

@gosipyan gosipyan force-pushed the sensor_test branch 2 times, most recently from f924db1 to 6e0fe4b Compare September 27, 2024 08:49
@gosipyan gosipyan force-pushed the sensor_test branch 10 times, most recently from 1bfa824 to 73a2ced Compare October 2, 2024 11:25
@gosipyan gosipyan force-pushed the sensor_test branch 5 times, most recently from 4a26c75 to 1c5310d Compare October 7, 2024 07:52
@gosipyan gosipyan marked this pull request as ready for review October 7, 2024 08:46
@gosipyan gosipyan force-pushed the sensor_test branch 2 times, most recently from 1776548 to b2aa256 Compare October 7, 2024 10:56
@gosipyan
Copy link
Contributor Author

gosipyan commented Oct 7, 2024

i have run tests several times to make sure nothing fail see details in links provided in description.

djoreilly
djoreilly reviewed Oct 8, 2024
View reviewed changes
Copy link

@djoreilly djoreilly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we can add tests for the other artifacts in future PRs

tests/console/velociraptor_client_event_collect.pm
@@ -104,15 +100,26 @@ sub run {
assert_script_run "chmod +x /tmp/genfile$i.sh";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are only triggering SUSE.Linux.Events.ExecutableFiles here. We will need to test the other artifacts too.

@foursixnine foursixnine merged commit e676233 into os-autoinst:master Oct 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzedro dzedro dzedro approved these changes

@djoreilly djoreilly djoreilly approved these changes

@foursixnine foursixnine foursixnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gosipyan @foursixnine @djoreilly @dzedro