ldap: Instance Name #286
Open
ldap: Instance Name #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this pull request solves the problem only partially. You have to change the code for clients as well (same file, lines 478-479 and 485). Could you take a look? |
|
Good catch! Thank you. Cheers. |
This addresses an issue where if you have more than one LDAP instance running it will show "Active Directory or LDAP" for all instances making it hard to differentiate the instances. This updates the `getName()` function to grab the name from the config if available otherwise defaults to the default name.
JediKev
force-pushed
the
ldap/instance-name
branch
from
7f9ecb8
to
cb02abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where if you have more than one LDAP instance running it will show "Active Directory or LDAP" for all instances making it hard to differentiate the instances. This updates the
getName()function to grab the name from the config if available otherwise defaults to the default name.