Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bib: move to cheggaaa/pb/v3 #248

Merged
merged 1 commit into from
Mar 21, 2024
Merged

bib: move to cheggaaa/pb/v3 #248

merged 1 commit into from
Mar 21, 2024

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Mar 7, 2024

There is a new version of cheggaaa/pb that we should use. Minor API changes and the output changes slightly.

Fixes #246

@mvo5 mvo5 requested a review from ondrejbudai March 7, 2024 12:38
ondrejbudai
ondrejbudai previously approved these changes Mar 7, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks!

@ondrejbudai ondrejbudai enabled auto-merge March 7, 2024 12:46
@mvo5
Copy link
Collaborator Author

mvo5 commented Mar 7, 2024

So it seems like testing-farm fails but the URL with the failure log is not included in the GH action (sclorg/testing-farm-as-github-action#130) and I also don't see how else I can access the log. I'm sure there was a second status at some point with a link to the testing farm result but I don't see it anymore.

@rhatdan
Copy link
Contributor

rhatdan commented Mar 7, 2024

Needs a rebase.

@jamacku
Copy link

jamacku commented Mar 8, 2024

ondrejbudai
ondrejbudai previously approved these changes Mar 11, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still awesome

@ondrejbudai ondrejbudai added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 11, 2024
ondrejbudai
ondrejbudai previously approved these changes Mar 11, 2024
@ondrejbudai ondrejbudai added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@ondrejbudai
Copy link
Member

I think we need yet another rebase. :/ But I think that the CI is finally in a state when we can actually merge stuff (just merged two PRs).

@mvo5 mvo5 force-pushed the update-pb branch 2 times, most recently from 12e11c0 to 9785fb3 Compare March 20, 2024 09:50
kingsleyzissou
kingsleyzissou previously approved these changes Mar 20, 2024
@ondrejbudai ondrejbudai added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@ondrejbudai ondrejbudai added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@ondrejbudai ondrejbudai added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@mvo5 mvo5 requested a review from kingsleyzissou March 20, 2024 16:44
There is a new version of cheggaaa/pb that we should use. Minor
API changes and the output changes slightly.
@mvo5 mvo5 enabled auto-merge March 21, 2024 09:27
@mvo5 mvo5 requested a review from ondrejbudai March 21, 2024 09:27
@mvo5 mvo5 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into osbuild:main with commit 366c7e0 Mar 21, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github.com/cheggaaa/pb to the latest version
6 participants