Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update images to 0.11 #3722

Merged
merged 2 commits into from
Oct 10, 2023
Merged

go.mod: update images to 0.11 #3722

merged 2 commits into from
Oct 10, 2023

Conversation

ondrejbudai
Copy link
Member

Mainly to include:

  • distro/rhel9: Make /boot 600 MiB big on RHEL 9.3+
  • fedora: exclude sdubby
  • Minimal image builds

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

schutzbot

This comment was marked as outdated.

Sign in to view

schutzbot

This comment was marked as outdated.

Sign in to view

bcl
bcl previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming all those test failures are just intermittent problems.

supakeen
supakeen previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @bcl, are these failures expected on the edge tests?

@bcl
Copy link
Contributor

bcl commented Oct 6, 2023

Same as @bcl, are these failures expected on the edge tests?

I don't think so. Some of them are passing, it's hard to tell what's going on. I see one with an upload problem, others with 405 responses to a query. I tried re-triggering it, and it's running one of them, but I can't tell if the other failures are from before, or from the retry:

https://github.com/osbuild/rhel-edge-ci/actions/runs/6430373132

@bcl bcl mentioned this pull request Oct 6, 2023
Merged
3 tasks
@henrywang
Copy link
Member

edge-vsphere-cs9 and edge-vsphere-9 failure has been fixed by PR containers/podman#3724
The raw image failures are caused by BIOS boot removed by PR osbuild/images#176. RHEL for Edge team is discussing this change now.
The simplified-installer failures because raw image disk partition changed.
The new disk partition:

/dev/vda1     2048   262143   260096  127M EFI System
/dev/vda2   262144  1048575   786432  384M Linux extended boot
/dev/vda3  1048576 41943006 40894431 19.5G Linux filesystem

The old disk partition:

/dev/vda1     2048     4095     2048    1M BIOS boot
/dev/vda2     4096   264191   260096  127M EFI System
/dev/vda3   264192  1050623   786432  384M Linux extended boot
/dev/vda4  1050624 41943006 40892383 19.5G Linux filesystem

@thozza thozza dismissed stale reviews from supakeen and bcl via 75611e4 October 9, 2023 11:06
@thozza thozza requested a review from henrywang October 9, 2023 11:06
@thozza
Copy link
Member

thozza commented Oct 9, 2023

I made (hopefully correct) changes to EDGE image tests based on #3722 (comment) and rebased the PR on main.

@thozza thozza requested a review from supakeen October 9, 2023 11:08
@ondrejbudai
go.mod: update images to 0.11
13b01bb 
Mainly to include:

- distro/rhel9: Make /boot 600 MiB big on RHEL 9.3+
- fedora: exclude sdubby
- Minimal image builds

Signed-off-by: Ondřej Budai <[email protected]>
@ondrejbudai
cmd/gen-manifests: fix compilation with the latest images
4a83a75 
The latest images introduced a new blueprint option: minimal. Since we use
direct type-conversion, we need to add it also in gen-manifests. A warning
is also added, since this feature is considered experimental.

Signed-off-by: Ondřej Budai <[email protected]>
@ondrejbudai
Copy link
Member Author

Updated to 0.11. This version dropped the BIOS change for edge.

Backup of Tomas' commits:

@ondrejbudai ondrejbudai changed the title go.mod: update images to 0.9 go.mod: update images to 0.11 Oct 9, 2023
schutzbot
schutzbot reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 4a83a75 with the main merge-base ebc256b). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5253963745/artifacts/browse

schutzbot
schutzbot reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 4a83a75 with the main merge-base ebc256b). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5253964366/artifacts/browse

bcl
bcl approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack ack!

@henrywang
Copy link
Member

All Fedora 38 test failure is caused by issue containers/crun#1322

@ondrejbudai
Copy link
Member Author

Not sure what's up with F38, seems like something in podman changed...

@ondrejbudai ondrejbudai merged commit b228886 into osbuild:main Oct 10, 2023
67 of 70 checks passed
@ondrejbudai ondrejbudai deleted the bump branch October 10, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

@bcl bcl bcl approved these changes

@achilleas-k achilleas-k Awaiting requested review from achilleas-k

@thozza thozza Awaiting requested review from thozza

@henrywang henrywang Awaiting requested review from henrywang

@supakeen supakeen Awaiting requested review from supakeen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ondrejbudai @bcl @henrywang @thozza @supakeen @schutzbot