Rewrite depsolve external #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused subcommands of the `osbuild_external`. Signed-off-by: Simon de Vlieger <[email protected]>
This splits out the depsolve external along the lines of the previously written partition externals. Using the external is now a two-step process where you run one external in a define and then use its output to generate stages and sources. Signed-off-by: Simon de Vlieger <[email protected]>
In `images` we mock depsolves so we can run them very fast under test. This introduces the same functionality to the depsolve external. Signed-off-by: Simon de Vlieger <[email protected]>
Use a `const.internal` subkey for the dnf4 depsolving external. This follows the ideas set forth in the partition tables. `.const` means that the format can be considered un-changing and `.internal` means that this shouldn't be used directly but only through other externals in the same group. Signed-off-by: Simon de Vlieger <[email protected]>
This commit adds unit tests for the `gen_depsolve_dnf4` external to ensure we have the input data in our tests for reference and to also regression test that neither input or output changes accidentally.
This commit adds a minimal test to the code in the `make_depsolve_dnf4_curl_source` external. While writing this it also tweaks the input name to make it more clear that its a list of resolved package sets that is expected.
This commit adds a minimal test to the code in the `make_depsolve_dnf4_make_rpm` external. While writing this it also tweaks the input name to `packageset` to make it consistent with new input name of the `osbuild-make-dnf4-curl-source` external.
mvo5
force-pushed
the
rewrite-depsolve-1
branch
from
983a4a4
to
12b4f51
Compare
supakeen
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a split of of #202 which is getting a bit long. Here the new externals are added with their unit tests. They do the resolving now but are not yet concerned with special handling for the kernel or similar.
One merge we can do a PR that uses them in the centos example otk files and after that we can look into the "fishing out" of extra information like kernel version (or expose general details of packages, this is something to discuss :)
See the individual commits for details.
Note that this will require to rename "packages" -> "packagesets" (plural) for the curl external and "packages" to "packageset" (singular) for the rpm stage in #202 but that should be the only change here.