-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example/centos: qcow2 for ppc64le #230
base: main
Are you sure you want to change the base?
example/centos: qcow2 for ppc64le #230
Conversation
Import more reference manifests and implement deduplicated omnifests. These are lacking the use of the partition external, this will be done in the next commit. Signed-off-by: Simon de Vlieger <[email protected]>
Partition tables were only split by architecture. Let's also split them by type so we can add additional types. Later on we might want to do some cross-includes in the partition tables as well. Signed-off-by: Simon de Vlieger <[email protected]>
Adjusts the VHD partition tables to its 4 GiB size (with a lot of duplication against `default` for now) and uses it. Also regenerate the reference image due to changed UUIDs. Signed-off-by: Simon de Vlieger <[email protected]>
Duplicate VHD to VMDK partition table and use it, duplication is on purpose any deduplication is a follow up for now. Also regenerate the reference image due to changed UUIDs. Signed-off-by: Simon de Vlieger <[email protected]>
There is a bit of a mid-air collision, when we introduced the "smarter" gen-image-refs UUID handling in PR#212 some images were already open as PRs. These now need to manually be tweaked to the "predictable" uuids of root/boot.
As I understand it the manual adjustment to the UUIDs should not be necessary anymore. Make sure you're rebased (again) on top of #219. Make sure your images check out is up to date, and so are your externals and then generate the reference manifests and it should (tm) just work. Do I miss something @mvo5? |
(that's why the tests fail - they need images merged first) |
cdc084e
to
ffd7d55
Compare
It seems the issue is that ppc64le does not use "label" when creating the filesystems which the gen-images-ref script uses to find the uuids, I can look and see if alternatively it can use the fstab stage (iirc it was doing that originally but then got changed). Manual sed would work in the meantime to unblock you |
Implements the example of ppc64le support for qcow2
this is based on #219
so my changes are just the last two commits and this
needs osbuild/images#952 merged first
also I'm not sure if i should be doing this to patch the UUIDs in the test target?