Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: use otk files instead of otk.arguments #7

Merged
merged 1 commit into from
Apr 15, 2024

Commits on Apr 12, 2024

  1. RFC: use otk files instead of otk.arguments

    The use-case given (and maybe I'm missing other use-cases here) for
    the otk.arguments is currently "version" and "architecture".
    
    We could do this instead via a `fedora-39-amd64.yaml` file that
    just define those arguments. The upside of this is that we can
    easily see what combinations of version and architecture we
    support by looking at the top-level dir. It also simplifies the
    spec and we would not have to worry about validating arguments,
    i.e. how do we know that "-Dversion=41" is valid or not (if not
    valid it would probably mean down the line an include based on
    the version cannot be found and that presents challenges for a
    nice error message).
    
    It would also allow us to have symlinks when things do not change,
    e.g.
    ```
    rhel-9.3.yaml -> rhel-9.4.yaml
    ```
    
    But maybe I'm missing another use case for this? Even then I think
    the `fedora/39-amd64.yaml` has some merrits and is worth considering.
    mvo5 authored and achilleas-k committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9cf2c4c View commit details
    Browse the repository at this point in the history