Disable caching of julia modules in julia module storage #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
- Coverage 75.61% 75.51% -0.10%
==========================================
Files 55 55
Lines 4478 4477 -1
==========================================
- Hits 3386 3381 -5
- Misses 1092 1096 +4
|
|
Thanks @lgoettgens. Disabling the caching indeed fixes the issue, but it also disables an optimization. I am working on an alternative fix, we'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1044.
I must admit that I don't really know how the code works and why this now resolves the issue, but it seems to work (according to the added test).