Show banner again by default

[fingolfin]

... unless we are being loaded from Oscar (code for that taken from
Singular.jl); can (still) be overridden with the GAP_SHOW_BANNER
environment variable.

This is based on the recent PI decision on banners.

Note that this simply shows the default GAP banner, e.g.:

julia> using GAP
 ┌───────┐   GAP 4.11.0 of 29-Feb-2020
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-apple-darwin18.7.0-julia64-kv7-v1.4
 Configuration:  gmp 6.1.2, Julia GC, Julia 1.4.1, readline
 Loading the library and packages ...
 Packages:   GAPDoc 1.6.3, PrimGrp 3.4.0, SmallGrp 1.4.1, TransGrp 2.0.5
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'

I could change it to a custom banner, of course (discussion on that is ongoing between the PIs)

[codecov]

Codecov Report

Merging #429 into master will decrease coverage by 0.03%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   73.47%   73.43%   -0.04%     
==========================================
  Files          63       63              
  Lines        5055     5060       +5     
==========================================
+ Hits         3714     3716       +2     
- Misses       1341     1344       +3     

Impacted Files	Coverage Δ
src/GAP.jl	81.35% <41.66%> (-3.83%)	⬇️

[fieker]

looks good to me, inline with the other corners

[mohamed-barakat]

I also would prefer to see the banner. I am also thinking of a banner for HomalgProject which acknowledges the used computer algebra systems but does not show their versions to avoid in example files. But in an interactive session, it is nice if people see the components.

[ThomasBreuer]

gap_module is a local variable in __init__,
perhaps use it as an argument of run_it in order to use it inside this function.

My personal preference is not to show banners, but if there is an agreement that every cornerstone shall show a banner then I do not object.
(Wasn't there a convention for Julia packages to not show banners, see #334?)

[fingolfin]

@ThomasBreuer regarding Banners, see oscar-system/Oscar.jl#92

[fingolfin]

@ThomasBreuer fixed the gap_module issue

[fieker]

On Thu, Apr 30, 2020 at 07:50:43AM -0700, ThomasBreuer wrote: @ThomasBreuer requested changes on this pull request. `gap_module` is a local variable in `__init__`, perhaps use it as an argument of `run_it` in order to use it inside this function. My personal preference is not to show banners, but if there is an agreement that every ornerstone shall show a banner then I do not object. (Wasn't there a convention for Julia packages to not show banners, see #334?)

Yes to both. We, as PIs decided that our end-products have banners - when used interactively And yes, julia decided against a banner - except for Julia.

…

-- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: #429 (review)